fix(deps): use numpy>=2.0 on Python 3.13+ to restore Windows CI#166
Open
jg-codes wants to merge 1 commit intobundesAPI:mainfrom
Open
fix(deps): use numpy>=2.0 on Python 3.13+ to restore Windows CI#166jg-codes wants to merge 1 commit intobundesAPI:mainfrom
jg-codes wants to merge 1 commit intobundesAPI:mainfrom
Conversation
numpy 1.26.x has no Windows wheels for Python 3.13, which caused the 'Windows fatal exception: access violation' that led to excluding windows-latest+3.13 from the CI matrix in PR bundesAPI#160. Splits the numpy constraint: - keep ^1.26.2 for >=3.12,<3.13 (no behavior change for existing CI) - require >=2.0 for >=3.13 (numpy 2.x has Windows wheels for 3.13) Drops the windows-latest+3.13 exclusion from runtests.yml. poetry.lock regenerated; only the numpy entry changed (no unrelated dep drift). Note: Co-authored with Claude (Anthropic). Diagnosis verified locally on macOS-3.13 (full base + [all]-extras install + import tests pass); Windows verification deferred to CI. Fixes bundesAPI#159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
windows-latest + Python 3.13CI by bumping the numpy lower bound for Python 3.13+ to>=2.0. numpy 1.26.x has no Windows wheels for Python 3.13, which is the root cause of the "Windows fatal exception: access violation" that led to the matrix exclusion in #160.This is the minimal version of the fix. Total diff is ~7 source lines + a
poetry.lockregeneration that only updates thenumpyentry (no unrelated dependency drift).Supersedes #162 with a smaller, focused diff. Credit to @Prakhar0013 for the original diagnosis on Windows.
Changes
pyproject.toml: split the numpy constraint — keep^1.26.2forpython>=3.12,<3.13(preserves existing behavior on 3.12), require>=2.0forpython>=3.13..github/workflows/runtests.yml: drop thewindows-latest + 3.13exclusion now that the numpy constraint is fixed.poetry.lock: regenerated; only thenumpyentry changes (verified viagit diff poetry.lock | grep '^+name'returns onlynumpy).Verification
poetry checkclean (modulo a pre-existingde-luftqualitaetwarning unrelated to this change)poetry lock --no-cachesucceedspip install . && pip install .[all]on Python 3.13.3 (macOS) resolves numpy to 2.4.4;pytest tests/import_test.pypasses 3/3AI disclosure
Co-authored with Claude (Anthropic). Final review and merge decision remains with maintainers.
Fixes #159