Instruction file and minor code corrections from Claude Code#216
Open
olljanat-ai wants to merge 2 commits intoburmilla:masterfrom
Open
Instruction file and minor code corrections from Claude Code#216olljanat-ai wants to merge 2 commits intoburmilla:masterfrom
olljanat-ai wants to merge 2 commits intoburmilla:masterfrom
Conversation
Provides onboarding documentation covering build system, project structure, dependency management, custom forks rationale (runc, netlink), testing, and common pitfalls for AI-assisted development. https://claude.ai/code/session_01U8AphoBeKU1CDE8dsaQ9n3
- bonding.go: Fix cmd.Stdout = os.Stdin -> os.Stdout (modprobe output was being sent to stdin instead of stdout) - ipv4ll_linux.go: Replace addr.String()[:7] with strings.HasPrefix() to prevent potential panic on short address strings - ipv4ll_linux.go: Move rand.New() outside loop to avoid recreating the random generator on each iteration - netconf_linux.go: Fix gateway to use replace (add=false) instead of add (add=true) for the primary IPv4 gateway, matching the comment intent and preventing EEXIST errors when a default route exists https://claude.ai/code/session_01U8AphoBeKU1CDE8dsaQ9n3
olljanat-ai
force-pushed
the
claude/review-burmillaos-setup-3Zm19
branch
from
170147a to
e342a4a
Compare
olljanat-ai
changed the title
Member
|
@prologic I have been skipping pull requests for a while because there haven't been others but I think that it is time to start using those again with proper peer review practice. This should be relatively simple place to start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruction file and minor code corrections from Claude Code.