Skip to content

Naomi/step 1#13

Draft
naomiaro wants to merge 7 commits into
button-inc:mainfrom
naomiaro:naomi/step-1
Draft

Naomi/step 1#13
naomiaro wants to merge 7 commits into
button-inc:mainfrom
naomiaro:naomi/step-1

Conversation

@naomiaro
Copy link
Copy Markdown

Sqitch setup for the TODO app.

Copy link
Copy Markdown

@matthieu-foucault matthieu-foucault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread schema/deploy/todos.sql
SET client_min_messages = 'warning';

CREATE TABLE todo_app.todos (
id SERIAL PRIMARY KEY,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id SERIAL PRIMARY KEY,
id GENERATED ALWAYS AS IDENTITY PRIMARY KEY,

This is part of the SQL standard (while serial is not), and ensures that you always use a generated id (unless you explicitely use override system value in your insert)

@kriscooke kriscooke marked this pull request as draft March 29, 2022 17:10
@kriscooke
Copy link
Copy Markdown
Contributor

(marked as draft belatedly, just so that solutions don't accidentally get merged 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants