-
Notifications
You must be signed in to change notification settings - Fork 11
.NET 10 + .NET 11 TFMs with NativeAOT and Runtime Async support #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
bbf9845
Bump library TFMs to net10.0/net11.0; mark AOT-compatible
buvinghausen 9930e81
Drop redundant Microsoft.SourceLink.GitHub package reference
buvinghausen b958267
Add net11.0 to the test TFM matrix
buvinghausen 1c7786a
Enable Runtime Async for net11.0 test target
buvinghausen c2b0418
Add empty AOT smoke-test project
buvinghausen e59caaf
Exercise all generator codepaths in the AOT smoke-test
buvinghausen 5c3fd47
CI: install .NET 11 SDK and run AOT smoke-test publish
buvinghausen 3ae6d97
Release workflow: pack with the .NET 11 SDK
buvinghausen 10c2cc3
README: document .NET 10 / 11 / AOT / Runtime Async support
buvinghausen 08febcd
CLAUDE.md: correct generator-only layout and add net10/11+AOT context
buvinghausen 4bf7aa7
Post-review hygiene: explicit SelfContained + --no-restore on AOT pub…
buvinghausen d5d3522
Adapt editorconfig to .NET 11 latest-Recommended ruleset
buvinghausen 4b1df4d
Speed up GHA
buvinghausen d642c3e
Add AotSmokeTest project to solution file
buvinghausen 714ec0d
Light up C# syntax highlighting in generator raw-string literals
buvinghausen bf00787
Restore net8/net9 test matrix coverage in tests and CI setup
Copilot 8c94654
Dump it back out to .net8
buvinghausen 184b10c
Use version-based MSBuild condition for IsAotCompatible
Copilot 0271251
Apply latest review feedback on TFM condition and README
Copilot a5aa361
Fix docs
buvinghausen 5a03a42
Merge branch 'feature/net11-aot' of https://github.com/buvinghausen/T…
buvinghausen 5fc6699
AOT came w/ .NET 7
buvinghausen 529cda4
Smoke 8
buvinghausen 932328f
FIX CI
buvinghausen 87136a2
last fix
buvinghausen fc1559b
Address remaining review threads on TFMs, AOT condition, and docs
Copilot 1759265
Remove editorconfig exclusions
buvinghausen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <AnalysisLevel>latest-Recommended</AnalysisLevel> | ||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <ImplicitUsings>true</ImplicitUsings> | ||
| <LangVersion>latest</LangVersion> | ||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | ||
| <AnalysisLevel>latest-Recommended</AnalysisLevel> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,29 @@ | ||
| <Project> | ||
|
|
||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" Condition="'' != $([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" Condition="'' != $([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;net462;net8.0</TargetFrameworks> | ||
| <Authors>Joseph Musser,Brian Buvinghausen</Authors> | ||
| <Company>Buvinghausen Solutions</Company> | ||
| <Copyright>Copyright © $([System.DateTime]::UtcNow.ToString("yyyy")) Brian Buvinghausen</Copyright> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageReadmeFile>README.md</PackageReadmeFile> | ||
| <PackageProjectUrl>https://github.com/buvinghausen/TaskTupleAwaiter/blob/master/README.md</PackageProjectUrl> | ||
| <PackageTags>C# 7.0;Value Tuple;Async Await Elegant Code</PackageTags> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild> | ||
| <PackageOutputPath>..\..\</PackageOutputPath> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <Authors>Joseph Musser,Brian Buvinghausen</Authors> | ||
| <Company>Buvinghausen Solutions</Company> | ||
| <ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild> | ||
| <Copyright>Copyright © $([System.DateTime]::UtcNow.ToString("yyyy")) Brian Buvinghausen</Copyright> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</IsAotCompatible> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageOutputPath>..\..\</PackageOutputPath> | ||
| <PackageProjectUrl>https://github.com/buvinghausen/TaskTupleAwaiter/blob/master/README.md</PackageProjectUrl> | ||
| <PackageReadmeFile>README.md</PackageReadmeFile> | ||
| <PackageTags>C# 7.0;Value Tuple;Async Await Elegant Code</PackageTags> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <TargetFrameworks>netstandard2.0;net462;net8.0</TargetFrameworks> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="*" PrivateAssets="All" /> | ||
| <None Include="../../LICENSE.txt" Pack="true" PackagePath="$(PackageLicenseFile)" /> | ||
| <None Include="../../README.md" Pack="true" PackagePath="$(PackageReadmeFile)" /> | ||
| <InternalsVisibleTo Include="$(AssemblyName).Tests" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="../../LICENSE.txt" Pack="true" PackagePath="$(PackageLicenseFile)" /> | ||
| <None Include="../../README.md" Pack="true" PackagePath="$(PackageReadmeFile)" /> | ||
| <InternalsVisibleTo Include="$(AssemblyName).Tests" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Text; | ||
|
|
||
| namespace TaskTupleAwaiter.Generator; | ||
|
|
||
| static class CSharpEmit | ||
| { | ||
| // Identical to StringBuilder.AppendLine at runtime; the [StringSyntax("C#")] annotation | ||
| // is what Visual Studio 2022 and JetBrains Rider use to syntax-highlight the raw-string | ||
| // content at each call site as C# instead of as opaque text. | ||
| public static StringBuilder AppendCSharp(this StringBuilder sb, [StringSyntax("C#")] string code) => | ||
| sb.AppendLine(code); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Polyfill for System.Diagnostics.CodeAnalysis.StringSyntaxAttribute (added in .NET 7). | ||
| // The generator project targets netstandard2.0, so the BCL definition isn't available. | ||
| // Roslyn's IDE classifiers recognise the attribute by namespace + type name (not assembly | ||
| // identity), so an internal declaration here drives the embedded-language hint in VS / Rider. | ||
| #pragma warning disable IDE0130 // Namespace does not match folder structure | ||
| namespace System.Diagnostics.CodeAnalysis; | ||
| #pragma warning restore IDE0130 // Namespace does not match folder structure | ||
|
|
||
| [AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property, AllowMultiple = false)] | ||
| sealed class StringSyntaxAttribute(string syntax) : Attribute | ||
| { | ||
| public string Syntax { get; } = syntax; | ||
| } |
22 changes: 11 additions & 11 deletions
22
src/TaskTupleAwaiter.Generator/TaskTupleAwaiter.Generator.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <IsRoslynComponent>true</IsRoslynComponent> | ||
| <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> | ||
| <IsPackable>false</IsPackable> | ||
| <GenerateDocumentationFile>false</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> | ||
| <IsPackable>false</IsPackable> | ||
| <IsRoslynComponent>true</IsRoslynComponent> | ||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="*" PrivateAssets="all" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="*" PrivateAssets="all" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.