Skip to content

fix(events): use terse route availability copy - #442

Merged
harshtandiya merged 3 commits into
developfrom
fix/434-route-availability-copy
Sep 8, 2026
Merged

fix(events): use terse route availability copy#442
harshtandiya merged 3 commits into
developfrom
fix/434-route-availability-copy

Conversation

@harshtandiya

@harshtandiya harshtandiya commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

What changed

The event URL field said availability in full sentences, one per reason. EventRoute.vue
already renders the message beside a check / triangle-alert icon in green or red, so the
icon and colour carry the verdict — the text only needs the status word (per #434).

Two states now, not four. A reserved route and a blank one read the same as a claimed
one: the organiser types a different route either way, so why it is unavailable is noise.

case before after
free This route is available. Available
taken This route is already taken. Already exists
reserved '{0}' is reserved and cannot be used. Already exists
blank Enter a route. Already exists

Backend-only (route_availability in buzz/api/events/services.py); strings stay in _()
and RouteAvailability's shape is unchanged.

Closes #434

Demo

free taken reserved
Available Already exists Reserved

The blank case has no shot: the component clears the message on an empty field, so it
never reaches the screen. The branch is kept for API callers.

Testing

  • bench run-tests --module buzz.api.events.test_events — 80 passed. The route tests
    assert on .available, which did not change.
  • Screenshots above taken against a local bench on this branch.
  • e2e/tests/manage-event.spec.ts had three assertions on the old copy; all retargeted.
    Not run locally — left to CI.

claude and others added 2 commits September 7, 2026 21:42
The event URL field said "This route is available." / "This route is
already taken." - wording issue #434 flagged as jargon-adjacent. The
check/alert icon and green/red colour already carry success and failure,
so the message only needs the status word.

Closes #434

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016kQ1Dp7xRj9mVNuYGeVYB2
A reserved or blank route now reads the same as a claimed one: the organiser types a different route either way, so the reason it is unavailable is noise.
@harshtandiya
harshtandiya marked this pull request as ready for review September 8, 2026 06:00
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR simplifies event-route availability messages while preserving availability decisions and response structure.

  • Consolidates blank, reserved, and claimed routes under “Already exists.”
  • Replaces the successful availability sentence with “Available.”
  • Updates end-to-end assertions for the new exact copy.

Confidence Score: 5/5

The PR appears safe to merge because it preserves route-availability behavior and updates the affected end-to-end expectations consistently.

No actionable failures remain; short-circuit evaluation retains the prior blank and reserved-route behavior, and the UI tests reliably match the new rendered messages.

Important Files Changed

Filename Overview
buzz/api/events/services.py Consolidates unavailable-route handling and shortens translated availability messages without changing boolean semantics.
e2e/tests/manage-event.spec.ts Updates route-availability assertions to verify the new exact copy for free, claimed, and reserved routes.

Reviews (1): Last reviewed commit: "Merge branch 'develop' into fix/434-rout..." | Re-trigger Greptile

@harshtandiya
harshtandiya merged commit e12ec37 into develop Sep 8, 2026
9 checks passed
@harshtandiya
harshtandiya deleted the fix/434-route-availability-copy branch September 8, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

route -> ".. slug is availble"

2 participants