fix(events): use terse route availability copy - #442
Merged
Conversation
The event URL field said "This route is available." / "This route is already taken." - wording issue #434 flagged as jargon-adjacent. The check/alert icon and green/red colour already carry success and failure, so the message only needs the status word. Closes #434 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kQ1Dp7xRj9mVNuYGeVYB2
A reserved or blank route now reads the same as a claimed one: the organiser types a different route either way, so the reason it is unavailable is noise.
harshtandiya
marked this pull request as ready for review
September 8, 2026 06:00
Contributor
Greptile SummaryThe PR simplifies event-route availability messages while preserving availability decisions and response structure.
Confidence Score: 5/5The PR appears safe to merge because it preserves route-availability behavior and updates the affected end-to-end expectations consistently. No actionable failures remain; short-circuit evaluation retains the prior blank and reserved-route behavior, and the UI tests reliably match the new rendered messages.
|
| Filename | Overview |
|---|---|
| buzz/api/events/services.py | Consolidates unavailable-route handling and shortens translated availability messages without changing boolean semantics. |
| e2e/tests/manage-event.spec.ts | Updates route-availability assertions to verify the new exact copy for free, claimed, and reserved routes. |
Reviews (1): Last reviewed commit: "Merge branch 'develop' into fix/434-rout..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The event URL field said availability in full sentences, one per reason.
EventRoute.vuealready renders the message beside a check / triangle-alert icon in green or red, so the
icon and colour carry the verdict — the text only needs the status word (per #434).
Two states now, not four. A reserved route and a blank one read the same as a claimed
one: the organiser types a different route either way, so why it is unavailable is noise.
This route is available.AvailableThis route is already taken.Already exists'{0}' is reserved and cannot be used.Already existsEnter a route.Already existsBackend-only (
route_availabilityinbuzz/api/events/services.py); strings stay in_()and
RouteAvailability's shape is unchanged.Closes #434
Demo
The blank case has no shot: the component clears the message on an empty field, so it
never reaches the screen. The branch is kept for API callers.
Testing
bench run-tests --module buzz.api.events.test_events— 80 passed. The route testsassert on
.available, which did not change.e2e/tests/manage-event.spec.tshad three assertions on the old copy; all retargeted.Not run locally — left to CI.