feat(dashboard): add a report an issue link to the account menu - #443
Open
harshtandiya wants to merge 4 commits into
Open
feat(dashboard): add a report an issue link to the account menu#443harshtandiya wants to merge 4 commits into
harshtandiya wants to merge 4 commits into
Conversation
Opens the GitHub new-issue page in a new tab from the account popover, placed above the Log Out divider so the destructive action stays last. Closes #432 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kQ1Dp7xRj9mVNuYGeVYB2
Settings and Log Out carry no leading icon, so an icon on this row alone left the three menu items with mismatched label alignment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kQ1Dp7xRj9mVNuYGeVYB2
The menu was a Popover holding ghost buttons, so it announced itself as a dialog and had none of a menu's behaviour: no arrow keys, no type-ahead, no focus containment, and a tab order that ran off the end into the page behind it. frappe-ui's Dropdown supplies all of that, and the options array is shorter than the markup it replaces. Carried over on the way: icons on every row, to match the sidebar items directly above; a Theme row that keeps the menu open, since a switch-type option renders outside the menu-item primitive; aria-pressed on the theme buttons, which were previously only distinguishable by fill; and __() on the labels, which the rest of the dashboard already had. Log Out is the one irreversible action in the shell and it ran bare: no pending state and no error path, so a slow request looked like a dead click and a failed one was silent. It now disables itself while in flight and the resource reports a failure. The trigger's aria-label was overriding its own contents, so a screen reader never read the signed-in name. An sr-only span names the control instead. The e2e locator moves to a test id because the settings dialog hides the sidebar from the accessibility tree while it is open.
harshtandiya
marked this pull request as ready for review
September 8, 2026 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdown, so it gets arrow keys and focus containment instead of behaving like a dialog.aria-label, which was hiding the signed-in name from screen readers.Closes #432