Skip to content

fix(navigation): remove legacy desk fixtures - #449

Merged
harshtandiya merged 2 commits into
developfrom
fix/remove-legacy-navigation-fixtures
Sep 8, 2026
Merged

fix(navigation): remove legacy desk fixtures#449
harshtandiya merged 2 commits into
developfrom
fix/remove-legacy-navigation-fixtures

Conversation

@harshtandiya

Copy link
Copy Markdown
Collaborator

Summary

  • remove the legacy Workspace Sidebar fixture
  • remove the dependent Desktop Icon fixture
  • rely on Frappe generated module navigation and the existing add_to_apps_screen hook

Context

Frappe develop fails while converting the legacy Buzz sidebar because its title is Buzz, its module is Events, and Buzz is also a registered module name. Removing the retired fixtures avoids that invalid conversion path.

Verification

  • pre-commit checks passed
  • git diff --check passed
  • confirmed no remaining Workspace Sidebar or Desktop Icon references in Buzz source

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the legacy Buzz Workspace Sidebar and its dependent Desktop Icon fixture so Frappe uses the modern generated navigation mechanisms instead.

  • Retains the public Buzz Workspace for Desk navigation.
  • Retains the Buzz apps-screen entry, including its permission check and /b route.
  • Removes the invalid legacy sidebar conversion path described by the PR.

Confidence Score: 5/5

The PR appears safe to merge because it removes only legacy navigation fixtures while retaining the supported Buzz Workspace and apps-screen registration.

No concrete behavioral, security, or repository-rule violation remains after verifying the supported Frappe range and the retained navigation configuration.

Important Files Changed

Filename Overview
buzz/desktop_icon/buzz.json Deletes the legacy Desktop Icon that linked to the retired Buzz Workspace Sidebar.
buzz/workspace_sidebar/buzz.json Deletes the legacy Workspace Sidebar while the supported modern Buzz Workspace remains available.

Reviews (1): Last reviewed commit: "Merge branch 'develop' into fix/remove-l..." | Re-trigger Greptile

@harshtandiya
harshtandiya merged commit 22fa3f8 into develop Sep 8, 2026
9 checks passed
@harshtandiya
harshtandiya deleted the fix/remove-legacy-navigation-fixtures branch September 8, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant