Skip to content

fix(dashboard): point event links at /events/<route> - #450

Merged
harshtandiya merged 1 commit into
developfrom
claude/eventroute-publicpath-navigation-ebol9x
Sep 8, 2026
Merged

fix(dashboard): point event links at /events/<route>#450
harshtandiya merged 1 commit into
developfrom
claude/eventroute-publicpath-navigation-ebol9x

Conversation

@harshtandiya

Copy link
Copy Markdown
Collaborator

What changed

The public event page lives at /events/<event_route>, but the dashboard built links to it two different (and both wrong) ways:

  • EventRoute.vue — the Event URL field on Event Details pointed at /b/register/<route>.
  • eventUrl() — hung the route straight off the origin, so the Event Drawer's Event Page button landed on /<route>.

Both now go through one helper:

  • eventUrl(route)<origin>/events/<route> (also what Copy Link puts on the clipboard).
  • eventPath(route)/events/<route>, used for the anchor's href.
  • openEventPage(route) → opens the public page with window.open, a plain navigation rather than one the SPA router (based at /b) could claim. Used by the Event URL arrow link (@click.prevent) and the drawer's Event Page button.

The Event URL field prefix now reads <host>/events/ so the field shows the address it actually is.

Demo

No visual change beyond the field prefix now reading <host>/events/ instead of <host>/; the fix is in where the links go.

Testing

  • node --test dashboard/src/utils/eventUrl.test.ts — updated for the new path, plus a case for eventPath. Passing.
  • Updated the e2e assertion in e2e/tests/manage-event.spec.ts to expect href="/events/<route>".
  • Pre-existing unrelated failures in timeZones.test.ts / timelineTabs.test.ts are untouched by this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PdA87qK8nUEBfAxs9cGzjJ


Generated by Claude Code

The public event page lives at /events/<route>, but the dashboard built its
links two other ways: the route field on Event Details pointed at
/b/register/<route>, and eventUrl() hung the route straight off the origin,
so the drawer's Event Page button landed on /<route>.

Both now go through eventUrl/eventPath, and opening the page is a plain
window navigation rather than an anchor the router could claim.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdA87qK8nUEBfAxs9cGzjJ
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

UI Demo Check — skipped via the skip-demo label.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the corrected event paths are applied consistently and no actionable regression was identified.

Summary

  • Adds shared helpers for absolute URLs, origin-relative paths, and plain new-tab navigation.
  • Updates the event drawer and event-route field to use the shared helpers.
  • Updates unit and end-to-end expectations for the corrected public path.

@harshtandiya harshtandiya added the skip-demo Skip adding a video / screenshot in PR description. Passes the failing CI for demo addition label Sep 8, 2026
@harshtandiya
harshtandiya merged commit 855e474 into develop Sep 8, 2026
10 of 11 checks passed
@harshtandiya
harshtandiya deleted the claude/eventroute-publicpath-navigation-ebol9x branch September 8, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-demo Skip adding a video / screenshot in PR description. Passes the failing CI for demo addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants