fix(dashboard): point event links at /events/<route> - #450
Merged
harshtandiya merged 1 commit intoSep 8, 2026
Merged
Conversation
The public event page lives at /events/<route>, but the dashboard built its links two other ways: the route field on Event Details pointed at /b/register/<route>, and eventUrl() hung the route straight off the origin, so the drawer's Event Page button landed on /<route>. Both now go through eventUrl/eventPath, and opening the page is a plain window navigation rather than an anchor the router could claim. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PdA87qK8nUEBfAxs9cGzjJ
Contributor
|
✅ UI Demo Check — skipped via the |
Contributor
harshtandiya
deleted the
claude/eventroute-publicpath-navigation-ebol9x
branch
September 8, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The public event page lives at
/events/<event_route>, but the dashboard built links to it two different (and both wrong) ways:EventRoute.vue— the Event URL field on Event Details pointed at/b/register/<route>.eventUrl()— hung the route straight off the origin, so the Event Drawer's Event Page button landed on/<route>.Both now go through one helper:
eventUrl(route)→<origin>/events/<route>(also what Copy Link puts on the clipboard).eventPath(route)→/events/<route>, used for the anchor'shref.openEventPage(route)→ opens the public page withwindow.open, a plain navigation rather than one the SPA router (based at/b) could claim. Used by the Event URL arrow link (@click.prevent) and the drawer's Event Page button.The Event URL field prefix now reads
<host>/events/so the field shows the address it actually is.Demo
No visual change beyond the field prefix now reading
<host>/events/instead of<host>/; the fix is in where the links go.Testing
node --test dashboard/src/utils/eventUrl.test.ts— updated for the new path, plus a case foreventPath. Passing.e2e/tests/manage-event.spec.tsto expecthref="/events/<route>".timeZones.test.ts/timelineTabs.test.tsare untouched by this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01PdA87qK8nUEBfAxs9cGzjJ
Generated by Claude Code