fix(dashboard): UI fixes from #455 - #456
Merged
Merged
Conversation
…chrome The G+S hint on the account menu's Settings row is clutter for everyone who never uses it; the shortcut is still registered and still listed in the keyboard shortcuts dialog. The settings sidebar's Profile row used the user's own picture where its siblings use icons, so it now uses one too.
…kets The schedule section was the only one in the right column carrying padding, so its heading sat 16px right of every other label. Each section now carries the same padding, with the fill left on the two that take input, and the column gap comes down since the sections space themselves. On the printed ticket, line-clamp never applied: the sibling `block` class wins over the display it sets, so a long event title ran past two lines and pushed the venue and ticket type out of the card's fixed height. Dropping `block` lets both clamps bite, and the title comes down a size to leave room.
The About field was already a tiptap editor, but with no menu: organisers had no way to reach a heading or a list short of knowing the markdown shortcuts. Both event pages now mount the same fixed toolbar the proposal and communication editors use, with the padding moved onto the content so the toolbar sits flush under its own divider. That shared config is no longer proposal-specific, so it moves to utils/richTextEditor.ts under names that say what it is.
The headline was an input, which cannot wrap: anything past the column width just scrolled off the right edge. It is a one-row textarea now, grown to fit by useTextareaAutosize, with Enter swallowed since a title has no second line of its own. The border and focus ring go with it, so the title sits flush above its description.
Only the schedule keeps a card now. The padding stays, so every label in the column still shares one left edge.
Contributor
|
✅ UI Demo Check — a screenshot or demo is attached. |
Contributor
 The PR appears safe to merge after considering the non-blocking keyboard-focus styling regression in the event-details title.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| aria-label="Event title" | ||
| placeholder="Name your event" | ||
| class="-mx-1 w-full rounded-4 bg-transparent px-1 text-4xl font-semibold text-ink-gray-9 placeholder:text-ink-gray-4 focus:outline-none focus-visible:ring-2 focus-visible:ring-outline-gray-3" | ||
| class="w-full resize-none overflow-hidden border-0 bg-transparent p-0 text-4xl font-semibold text-ink-gray-9 placeholder:text-ink-gray-4 focus:outline-none" |
Contributor
There was a problem hiding this comment.
The new textarea removes the previous focus-visible:ring-2 styling while also suppressing the browser's default outline. Keyboard users therefore receive no visible focus indicator when editing the event title. Please preserve an explicit focus-visible style.
Prompt To Fix With AI
This is a comment left during a code review.
Path: dashboard/src/pages/manage/events/EventDetails.vue
Line: 211
Comment:
**Missing keyboard focus**
The new textarea removes the previous `focus-visible:ring-2` styling while also suppressing the browser's default outline. Keyboard users therefore receive no visible focus indicator when editing the event title. Please preserve an explicit focus-visible style.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #455 (all but the publish-state item, which we are not doing).
G+Schips from the account menu's Settings row; shortcut still works and is still in the shortcuts dialogline-clampnever applied because a siblingblockclass overrode its display, so long titles pushed the venue out of the cardutils/richTextEditor.tsDemo
Event details — aligned column, editor toolbar, wrapped title:
Settings sidebar, account menu:
Ticket at a worst-case title and venue:
Testing
Manual, in the browser: both event pages, the settings dialog, and the guest drawer's ticket at a worst-case title and venue.