feat: JPEG/PNG download choice on shared folder/project pages

[vishwajeet-13]

Problem

Reported: on a /vms/shared/folder/…?token=… link, a guest downloading a .arw still gets the .arw — no JPEG/PNG option.

The format menu from #157 was wired into the review page and the asset action menu only. The shared folder / shared project page (SharedProjectPage.vue) has its own download path (vms.api.get_shared_asset_download_url → presigned original) that #157 never touched.

Fix

Backend — vms.api.download_shared_converted_asset(asset_name, format, project?, token?, folder?)

• allow_guest, validated with _validate_shared_asset_scope (identical to get_shared_asset_download_url)
• delegates to serve_converted_download → same 300 MB cap, @rate_limit (15/min, keyed on asset), embedded-preview render for RAW / libheif for HEIC

Frontend

• SharedProjectPage.vue: the per-card Download button becomes Original (ARW) / JPEG / PNG for RAW/HEIC stills (isConvertibleStill); other files and Download all unchanged (originals)
• MediaPreviewDialog.vue: new optional downloadMenu prop — when set, the preview header's Download button renders the same menu; unset keeps the plain link (other callers unaffected)

Screenshot

Guest shared-folder page, ARW card:

Verified (local, live site)

• Guest menu renders Original/JPEG/PNG on the ARW card; clicking JPEG triggers a download named DSC02816.jpg
• Endpoint probes: valid → reaches convert path; bad token → 401; bad format → 417; asset outside the share → 404
• yarn typecheck / yarn lint / yarn build clean; ruff check / ruff format clean

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR adds JPEG and PNG conversion downloads to shared project and folder pages while preserving original downloads.

• Adds a guest-accessible, rate-limited conversion endpoint with shared-scope validation.
• Adds Original/JPEG/PNG menus to convertible asset cards and previews.
• Extends MediaPreviewDialog with an optional download menu without changing existing callers.
• Automated coverage is still needed for the new guest authorization boundary.

Confidence Score: 4/5

The PR appears safe to merge, with the non-blocking recommendation to add automated coverage for the new public endpoint’s authorization branches.

The endpoint reuses established scope validation and guarded conversion behavior, and the frontend wiring is compatible with existing callers; the only accepted concern is missing regression coverage for the guest-accessible boundary.

Files Needing Attention: vms/api.py

Important Files Changed

Filename	Overview
vms/api.py	Adds the scoped guest conversion-download endpoint; implementation follows existing authorization and conversion paths, but lacks endpoint regression tests.
frontend/src/pages/SharedProjectPage.vue	Adds conversion menus to shared asset cards and previews using the existing scope and download conventions.
frontend/src/components/common/MediaPreviewDialog.vue	Adds an optional frappe-ui download dropdown while retaining the existing plain download button behavior.

Prompt To Fix All With AI

### Issue 1
vms/api.py:2258
**Guest Endpoint Lacks Tests**

The new guest-accessible endpoint has no automated regression coverage for valid project and folder shares, invalid tokens, or assets outside the shared scope. These authorization branches protect a public download path, so relying only on manual probes makes future scope-validation regressions difficult to detect. Please add focused endpoint tests for successful project and folder downloads and the rejection cases.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "feat: JPEG/PNG download choice on shared..." | Re-trigger Greptile}

[greptile-apps]

Guest Endpoint Lacks Tests

The new guest-accessible endpoint has no automated regression coverage for valid project and folder shares, invalid tokens, or assets outside the shared scope. These authorization branches protect a public download path, so relying only on manual probes makes future scope-validation regressions difficult to detect. Please add focused endpoint tests for successful project and folder downloads and the rejection cases.

Prompt To Fix With AI

This is a comment left during a code review.
Path: vms/api.py
Line: 2258

Comment:
**Guest Endpoint Lacks Tests**

The new guest-accessible endpoint has no automated regression coverage for valid project and folder shares, invalid tokens, or assets outside the shared scope. These authorization branches protect a public download path, so relying only on manual probes makes future scope-validation regressions difficult to detect. Please add focused endpoint tests for successful project and folder downloads and the rejection cases.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!