Skip to content

Default to MapLibre and load Mapbox externally#3

Open
bwstefano wants to merge 1 commit into
codex/jeo-public-metadata-syncfrom
codex/maplibre-default-mapbox-external-runtime
Open

Default to MapLibre and load Mapbox externally#3
bwstefano wants to merge 1 commit into
codex/jeo-public-metadata-syncfrom
codex/maplibre-default-mapbox-external-runtime

Conversation

@bwstefano
Copy link
Copy Markdown
Owner

Summary

  • default the JEO runtime to MapLibre, require a Mapbox API key before saving the Mapbox option, and surface the settings validation error in the admin UI
  • remove the bundled Mapbox SDK/React wrapper, load Mapbox GL JS externally from the Mapbox CDN when requested, and keep runtime fallback notices, smoke assertions, and bundle-size budgets aligned with the unified mapgl bundles
  • make map previews autosave-aware and align popup, fullscreen, attribution, and compact-control behavior across maps, storymaps, and Discovery while keeping the Mapbox attribution requirements explicit
  • converge repository and package metadata on GPL-3.0-only and document Mapbox as an optional external integration rather than bundled plugin code

Testing

  • npm run check:env
  • npm run build
  • npm run build:report
  • npm run test:unit -- --passWithNoTests
  • vendor/bin/phpcs --standard=phpcs.xml.dist
  • php scripts/check-php-compat.php
  • WP_CLI_PHP=/opt/homebrew/opt/php@8.4/bin/php WP_DIR=/tmp/jeo-plugin-wordpress-smoke bash scripts/wordpress-smoke.sh

Stack

Make MapLibre the default runtime in settings, require a Mapbox API key before saving Mapbox, and load the Mapbox SDK from api.mapbox.com with runtime fallback notices instead of bundling it.

Refresh the shared map wrappers, preview payload handling, attribution and control styling across maps, storymaps, and Discovery; remove the dedicated Mapbox React wrapper; and keep previews, hover popups, compact attribution, and manual QA follow-ups aligned with the new runtime split.

Align repository metadata and validation with the GPL-3.0-only packaging path by updating manifest/license metadata, smoke assertions, and bundle-size budgets for the unified mapgl bundles.

Validated with:
- npm run check:env
- npm run build
- npm run build:report
- npm run test:unit -- --passWithNoTests
- vendor/bin/phpcs --standard=phpcs.xml.dist
- php scripts/check-php-compat.php
- WP_CLI_PHP=/opt/homebrew/opt/php@8.4/bin/php WP_DIR=/tmp/jeo-plugin-wordpress-smoke bash scripts/wordpress-smoke.sh

Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant