feat(form): annotated_image field — mark point/region (#24) - #150
Merged
Conversation
iret77
force-pushed
the
feat/issue-24-annotated-image
branch
from
August 1, 2026 09:50
0284862 to
68a096a
Compare
#24) New form field that shows an image and lets the user mark it directly — for spatial answers words carry poorly ("where should the logo go?", "which part do I crop?", "point at the bug in this screenshot"). - mode "point" (default): click a single crosshair marker - mode "region": drag a rectangle - mode "both": Point/Region toggle; both can be set `src` reuses the existing image resolution (absolute / ~/ local path inlined by the bridge, http(s):// fetched Mac-side, or data:) via the shape-agnostic imageresolve walker — no new resolution path. Result, under the field name, is normalized 0..1 and resolution-independent: {point:{x,y}|null, region:{x,y,w,h}|null, natural:{width,height}|null}; `natural` (intrinsic pixel size, set on load) recovers pixels losslessly. `required` gates the submit action on an annotation being present. Interaction is pointer-capture based (works for mouse/touch/pen); a sub-threshold region drag is treated as a stray click and discarded rather than committing a degenerate rect. Overlay is an SVG viewBox 0..100 stretched over the image so markers track any display size. - Form.svelte: field type, init, validation, render + styles - http.rs: add to KNOWN_FIELD_KINDS (+ validation test) - dialog.rs: window-size estimate arm - mcp.rs / python server.py: form tool-description field catalog - docs/skill.md, CHANGELOG.md Backend build/test not runnable on this headless Linux host (Tauri GUI crate needs GTK/glib system libs); frontend typecheck + build are green.
iret77
force-pushed
the
feat/issue-24-annotated-image
branch
from
August 1, 2026 09:54
68a096a to
176e3ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neues
annotated_image-Formularfeld: Bild anzeigen und Punkt (mode:point), Region (region) oder beides (both) markieren. Rückgabe normalisiert 0..1 plus intrinsische Pixelgröße (natural) für verlustfreie Pixel-Rückrechnung.srcnutzt die bestehende imageresolve-Auflösung.Build: FE (svelte-check/vite) grün; Rust-Edits trivial. Mac-E2E offen: Interaktion je Modus, required-Gating, Overlay-Ausrichtung bei Resize.
Closes #24
Batch-Kontext: Teil eines 6-PR-Sets (#141, #146, #23, #24, #25, #17) aus parallelen Sub-Sessions, das zusammen einen Release ergibt.
mainrebased (Hotspots:mcp.rs,http.rs,skill.md,CHANGELOG.md,server.py).main; Merge via PR (AGENTS.md). CI baut/testet; interaktives Dialog-E2E nur am Mac verifizierbar.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.