fix(bindgen): use ponyfill for Promise.withResolvers
#1156
Merged
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
approved these changes
Dec 8, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Hey @wooorm-arcjet thanks for contributing this -- happy to use a ponyfill here :)
Contributor
Author
|
Sweet! Re the CI error, what’s the scope i should use for the PR title? |
Collaborator
|
Ah, so the scope should be Also, I think that was a github CI test flake... once you change the scope it should re-run and probably pass this time! |
wooorm-arcjet
changed the title
Promise.withResolversPromise.withResolvers
Hi! Thanks for this project :) Polyfills are nice but [also have some problems](https://github.com/sindresorhus/ponyfill#the-problem-with-polyfills). Would it be of interest to use a ponyfill, along the lines of the changes in this PR, instead? Thanks for considering!
auto-merge was automatically disabled
December 8, 2025 13:39
Head branch was pushed to by a user without write access
wooorm-arcjet
force-pushed
the
promise-with-resolvers-ponyfill
branch
from
564dc30 to
179d459
Compare
Contributor
Author
|
done, you probably need to click “allow” tho! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this project :)
Polyfills are nice but also have some problems. Would it be of interest to use a ponyfill, along the lines of the changes in this PR, instead?
Thanks for considering!