fix(client): apply the package override before deriving identity - #250
Merged
Merged
Conversation
salmans
force-pushed
the
fix-package-override
branch
2 times, most recently
from
August 11, 2026 22:37
5b34332 to
35bddb9
Compare
The override was applied only after `(package, version)` had been extracted from the binary, so it could never supply a missing identity — and a compiled component never has one (it decodes as an unversioned `root:component`). Extract only when no override is given. The no-override constructor lost its callers and is folded into the override-taking one; the module is crate-private, no public API change.
salmans
force-pushed
the
fix-package-override
branch
from
August 12, 2026 14:25
35bddb9 to
721945c
Compare
salmans
marked this pull request as ready for review
August 18, 2026 19:42
mkatychev
approved these changes
Aug 19, 2026
mkatychev
left a comment
mkatychev
left a comment
Member
There was a problem hiding this comment.
LGTM, this will have to go in once 0.16.1 is released since it's a breaking change in the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DecodedComponent::from_publishing_source_with_packageextracted(package, version)from the decoded binary first and applied the override second, sopublish_release_datafailed for any binary without an embedded version before the override was consulted. A WIT package without a version that was published withPublishOpts { package: Some(..) }always failed with "version not found", even though that error's help text suggests supplying the identity explicitly.The change derives the identity from the binary only when no override is supplied. The change left the no-override constructor without callers, so the two constructors are collapsed into one that takes
Option<(PackageRef, Version)>; the module is crate-private, so there's no public API change.