This repository was archived by the owner on Jan 12, 2026. It is now read-only.
[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface#457
Merged
garyli1019 merged 11 commits intobytedance:masterfrom Mar 27, 2023
Merged
[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface#457garyli1019 merged 11 commits intobytedance:masterfrom
garyli1019 merged 11 commits intobytedance:masterfrom
Conversation
Contributor
|
Hi, @beyond-up , some suggestions:
|
beyond-up
changed the title
beyond-up
changed the title
Contributor
Author
ok, thx! |
Contributor
Author
I have modified, please help me review the code, thx @liuxiaocs7 |
garyli1019
reviewed
Mar 21, 2023
Collaborator
garyli1019
left a comment
garyli1019
left a comment
There was a problem hiding this comment.
@beyond-up thanks for your contribution, overall looks good. Left some minor comments
...-rocketmq/src/main/java/com/bytedance/bitsail/connector/rocketmq/sink/HashQueueSelector.java
Show resolved
Hide resolved
...q/src/main/java/com/bytedance/bitsail/connector/rocketmq/sink/format/RocketMQSinkFormat.java
Show resolved
Hide resolved
...r-rocketmq/src/main/java/com/bytedance/bitsail/connector/rocketmq/sink/RocketMQProducer.java
Show resolved
Hide resolved
…optimize RocketMQSerizationSchema
Contributor
Author
|
Thanks for you suggestions, I hava optimized my code ,please help me review the code ! @garyli1019 |
garyli1019
reviewed
Mar 24, 2023
...src/main/java/com/bytedance/bitsail/connector/rocketmq/constants/OptionalProducerConfig.java
Show resolved
Hide resolved
garyli1019
approved these changes
Mar 27, 2023
Collaborator
garyli1019
left a comment
garyli1019
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution! @beyond-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Title: [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface
Close: [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface #137
Motivation
Migrate rocketmq Sink connector to V1 interface and use BitSail unified streaming and batching interface
Modifications
Describe the modifications you've done.
Verifying this change
Please pick either of the following options.
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests, example:)
This change added tests and can be verified as follows:
(example:)
Documentation