This repository was archived by the owner on Jan 12, 2026. It is now read-only.
[BitSail-465][Test] Fix NullPointerException of testCreateGenericExecutor method#468
Open
Jake-00 wants to merge 4 commits intobytedance:masterfrom
Open
[BitSail-465][Test] Fix NullPointerException of testCreateGenericExecutor method#468Jake-00 wants to merge 4 commits intobytedance:masterfrom
Jake-00 wants to merge 4 commits intobytedance:masterfrom
Conversation
Contributor
Author
|
@hk-lrzy plz take a look, thx ☕ |
healchow
reviewed
Apr 16, 2023
...-e2e-base/src/main/java/com/bytedance/bitsail/test/e2e/executor/generic/GenericExecutor.java
Show resolved
Hide resolved
healchow
reviewed
Apr 16, 2023
...rc/test/java/com/bytedance/bitsail/test/e2e/executor/generic/GenericExecutorSettingTest.java
Show resolved
Hide resolved
Contributor
Author
|
hi @hk-lrzy , could you help to review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nericExecutor
Prepare a Pull Request
Title: [BitSail-465][Fix] fix NullPointerException of function testCreateGenericExecutor
Fixes: [Bug][Test] Test testCreateGenericExecutor method would fail with NullPointerException #465
Motivation
To deal with NullPointerException happening to function
testCreateGenericExecutor().Modifications
this.transferableFiles, constructor would operate in new commit.GenericExecutorSettingTest, so I delete the compare ofexecutortransferableFiles.Describe the modifications you've done.
Verifying this change
Please pick either of the following options.
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests, example:)
This change added tests and can be verified as follows:
(example:)
Documentation