Ldb kv recover#198
Open
yapple wants to merge 11 commits into
Open
Conversation
2. add kv_combine flags to compactor command 3. in class version_edit, we add rollback_ member as a switch to control encode process, and we check the sst' status, if we open the rollback_ switch, we will check the file's prop, like purpose, dependence, inheritance. 4. in class version_set, we add a public method manifestRollback, and we add a rollback param to the WriteSnapshot method.
2. struct SstFileMetaData add terarkdb_file member, the value is true Means the sst is a terarkdb file instead of rocksdb file
…llel compactFile 2. fix level0 FilesRangeOverlapWithCompaction issue
2. not chose level-1's file to compact
mm304321141
reviewed
Dec 30, 2021
| bool is_in_atomic_group_; | ||
| uint32_t remaining_entries_; | ||
|
|
||
| bool rollback_ = false; |
Collaborator
There was a problem hiding this comment.
调整一下变量定义的位置，尽量让所有的 bool 挨在一起
| s = Status::Corruption("Unable to encode VersionEdit:" + | ||
| e.DebugString(true)); | ||
| } | ||
| s = descriptor_log_->AddRecord(record); |
| uint64_t num_entries; | ||
| uint64_t num_deletions; | ||
| // true Means a terarkdb sst file instead of rocksdb file | ||
| bool non_origin_file; |
Collaborator
There was a problem hiding this comment.
移动一下 bool 定义的位置，尽可能让 bool 全都挨着
| for (auto& t : threads) { | ||
| t.join(); | ||
| } | ||
| if (NonOriginFiles.size() == 0) break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support terarkdb format rollback to rocksdb