Improvements: load all plants from keymap file, added features in searching mode (not completed):

[mipa83]

changed keymap file and loading criteria: skip comments (//) till newline arrives.

Integrated the behaviour of Key_CHS, Key_RUN, Key_E (EEX) in handle_editing(key)
To maintain a better overview following functions (called them “editing”, because they should be used only in editing modus):
• bool editing_chs();
• bool editing_eex_or_cycle_prefixes();
• bool editing_spc_equal_semicolon();
CHS: changes -to +: example: ‘5-3 CHS --> 5+3 (old was ‘53’)
EEX: check if there is already an exponent, so beep and move there, otherwise exponent with or without leading 1.
spc_equal_semicolon() works now also with alpha and lowercase.
CAT working in alpha and lowercase mode
Annunciator line/Header: I got confused with alpha, lowercase and user mode: so I rewrote the labelling:
static cstring lbls[] = { " ", " A", " a", "U ", "UA", "Ua", "1 ", "1A", "1a", };

Commands are shown now also in editing mode: example: Dark “cos” after pressing COS is shown now also while editing…; Dark “cos” disappears when releasing the key.

SEARCH improvements
“DROP” and “DEL” reduces the selection from right and left.
“LEFT” and “RIGHT” reduce or expand the selection
Key_E (EEX): works with search (Settings.ExponentSeparator())

some Minor changes…

The search command is not fully done yet, because I am at a point where I need help.
What is working so fare:
example (no alpha) SIN –> adds S, then I, then N to the search commands: beep with exit at the first not found unicode.
I would like to improve more – but I could not find a selection criteria for key function: command, menu, else, … can you give me some help on this?

[c3d]

Hey, @mipa83, this looks very interesting, but I would really like to cut a 0.9.16. There has been no release for a while, and there is a regression in shift logic which is really annoying. So I will not merge that for this release, and put that on my to-do list list for 0.9.17.

Thanks a lot!

[mipa83]

Hey, @c3d , thanks for creating db48x - it is very useful :-)
Unfortunately, I created a lot of comments - some of them are very useless and confusing - so better you extract the modifications and add them directly or should I edit the code (on the latest stable version) and create new, better comments?

[c3d]

Hi @mipa83 I think you mean "commits"? If so don't worry, I'll take care of that during the week-end. The problem is that you are touching really sensitive parts of the code and I want to make sure it works well.

[mipa83]

Yes, I did.
Just an other thought: splitting up (extracting) the stack operation from handle_editing(key) in an separate function might be a good idea for better code interpretation.

[mipa83]

I still have the idea in mind to add a (hp48) or (hp50) layout to the calc, which should/could be loaded easily by pressing F10 (in a very flexible way).
(db48x/src/dmcp/target.h)
hp48 has 6 keys more than the 42S
hp50 has 8 keys more than the 42S
Key 44 to key 49 for the extra row of the hp48
#define KB_ALPHA 50 //! Alpha
#define KB_LSHIFT 51 //! Left shift
#define KB_RSHIFT 52 //! Right shift
#define KB_UP 53 //! up arrow
#define KB_DN 54 //! down arrow
#define KB_LF 55 //! left arrow
#define KB_RT 56 //! right arrow
Key 57 for DEL (hp48)
....
Somehow an assignment to the model will be needed due to
different key actions --> user_interface
(Enter will be 13 on all models)
(EEX will be 16 on all models)
(new_line will be different on 42/48/50)
...
Different key layout --> dmcp_position different
Eliminate KB_A ... KB_Z --> making BASED dependent on the model
-->sim-window.cpp
-->target.cc (static const byte dmcp_position[])

Optional (for keeping the code small for the dm32/dm42)
#ifdef SIMULATOR
#endif // SIMULATOR
Just let me know what you think about it - I added this idea here, but maybe it would be a better idea to add it under
DB48X Discussion.

[c3d]

@mipa83 The main issue with the HP48 and HP50 layout relative to what I did for DB48x based on the HP42 is that they consume F1-F6 for alpha keys A through F. The upside is that you have alpha and numerical at teh same time. The downside is that all the uses of soft menus in alpha mode are bust. This includes editing functions (the edit menu), the character catalog, the function catalog, etc.

This is what has blocked me from even trying to replicate the HP48 / HP50 layout so far.