Skip to content

Correcting description of simulator m option#1671

Open
evgaster wants to merge 1 commit intoc3d:stablefrom
evgaster:stable
Open

Correcting description of simulator m option#1671
evgaster wants to merge 1 commit intoc3d:stablefrom
evgaster:stable

Conversation

@evgaster
Copy link
Copy Markdown

@evgaster evgaster commented Mar 29, 2026

The description for the m option of the simulator mentions megabyte. It should be kilobytes.

@evgaster
Copy link
Copy Markdown
Author

Sorry again about the non related commits that keep popping up. I wish I could get rid of them ... for good.

@ppigazzini
Copy link
Copy Markdown

ppigazzini commented Apr 2, 2026

Sorry again about the non related commits that keep popping up. I wish I could get rid of them ... for good.

You can fix in this way:

git switch stable
# make a new branch as backup
git switch -c stable_bkp
git switch stable
# I suppose that you have create the upstream with
# git remote add upstream https://github.com/c3d/db48x.git
git fetch -p upstream
git reset --hard upstream/stable
git cherry-pick c5abb63
git push -f origin HEAD

# if something should go wrong you can restore with
git switch stable_bkp
git push -f origin HEAD:stable

Next time it's better to open a PR using a different branch name wrt "stable" (your local and origin "stable" should simply track the upstream one).

@evgaster evgaster changed the title Correct description of simulator m option Correcting description of simulator m option Apr 5, 2026
@evgaster
Copy link
Copy Markdown
Author

evgaster commented Apr 5, 2026

@ppigazzini Thanks!

Next time it's better to open a PR using a different branch name wrt "stable" (your local and origin "stable" should be simply track the upstream one).

That's what I usually do ... Not sure what happened that caused this issue.

Tau mass constant had incorrect relative uncertainty.
It was based on Munon values.

Corrected the expression to use Tau values.

Signed-off-by: Ed@vanGasteren.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants