Open
Conversation
MSYS2 now removes libgnurx from the install set because it conflicts with libsystre, which is pulled in by the current Qt dependency graph. Update the Windows workflow to install libsystre and copy libsystre-0.dll and libtre-5.dll instead of the missing libgnurx-0.dll.
Generate recorder/config.h in the GitHub wasm job before the emsdk build so clean checkouts do not fail when recorder.c includes the header. Force host tools to build with OUTPUT=./ so wasm does not place ttf2font and decimize under nested wasm/ directories that the top-level rules do not invoke.
Author
There was a problem hiding this comment.
Pull request overview
This PR updates CI/build configuration to use newer tool/action versions and adjusts build outputs to match updated packaging expectations.
Changes:
- Bump GitHub Actions and Qt versions used in
.github/workflows/build.yml. - Update Windows MSYS2 dependencies and adjust copied DLL set and artifact paths.
- Update the
tools/%Makefile rule to pass anOUTPUT=./override to tool builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Passes OUTPUT=./ when building tools via make tools/%. |
| .github/workflows/build.yml | Updates action/Qt versions, adjusts Windows packaging, and adds a WASM pre-step to generate a recorder config header. |
ppigazzini
force-pushed
the
ci_bump_pkgs
branch
from
40df53e to
1163ef8
Compare
The color Windows job signs and uploads debug/db50x.exe and debug/* even though the build and windeployqt6 place the simulator files at the workspace root. Update the artifact and signing paths so the db50x archive includes the executable, deployed DLLs, Qt plugin directories, and help files. Use the same process for db48x.exe for consistency.
ppigazzini
force-pushed
the
ci_bump_pkgs
branch
from
1163ef8 to
5d0728b
Compare
Make the Android bundle path independent from the generic OUTPUT variable, which defaults to the workspace root in CI. Verify android/db48x.aab and android/db50x.aab before upload and fail the artifact step when no AAB is present.
ppigazzini
force-pushed
the
ci_bump_pkgs
branch
from
5d0728b to
23a92cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.