Fix: Root solver converges prematurely in Std display mode#1680
Open
Fix: Root solver converges prematurely in Std display mode#1680
Conversation
In Std mode, algebraic::epsilon() used DisplayDigits()+1=21 as convergence target regardless of Precision. Fixes c3d#1679
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679
In
Stdmode,algebraic::epsilon()usedDisplayDigits() + 1 = 21as the convergence target regardless of
Precision, causing the solverto stop after ~20 digits instead of
Precision - SolverImprecision.The fix skips the
std::min(disp+1, ...)clamp inStdmode and usesmax(prec - impr, 3)directly, consistent with documented behaviour.Tested:
Prec 1010,Std,'cos X-X' 'X' 0.7 Root→ ≥1004 accurate digits.