-
Notifications
You must be signed in to change notification settings - Fork 3
Add the first production-ready version of the external project overview #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nabalma
wants to merge
8
commits into
master
Choose a base branch
from
external-project-overview-first-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bb7795c
Consolidate the first production release of the external project over…
nabalma 70ea0c4
Remove the redundant FMS_ENV global declaration.
nabalma c282ad1
Remove the obsolete ESLint display-name suppression.
nabalma b2e648a
Apply Prettier formatting to the external project overview
nabalma ca840e5
ParentProject type added and format corrected in the viewset file.
nabalma 2b10fc3
using useMemo for openCount, uniquePIs, and uniqueRequestors functions
nabalma b9af9ad
iconStyle function is now out of the component
nabalma dae2a60
fix prettier checks on readset dashboard and project dashboard files
nabalma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UlysseFG Personally I feel this serializer should be a composition of models rather than individual fields. Like we could have a field for
parent_project,derived_sample,readset, etc. So that way, we know where each fields come from.