Avoid duplicating nixpkgs in the store harder (follow-up to #67)#125
Merged
sandydoo merged 1 commit intoMay 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to and a follow-up to #67 but does the same for
passthruFunMore or less because
pkgs.pathis of path type (rather than string type), doing${pkgs.path}causes an extra copying to the store because of the way string interpolation works on paths (when it is already a store path pointing to the flake source and should not need extra copying). This should be avoided by using the path directly as a string (alternatively this could be done viapkgs.path + "/..."as well, but this matches line 299 and they are functionally equivalent in this case)