toggle: add spawnThenToggle client option#117
Open
Qbushey wants to merge 2 commits into
Open
Conversation
Windows spawned via IPC (e.g. shell windows opened through 'caelestia shell ... open') ignore the [workspace special:X] exec rule, so the special workspace never opens on first toggle. The new option toggles the workspace open after spawning the client command. Fixes caelestia-dots#73
Contributor
|
This is more accurate for json files. I didn't really pay much attention to it. you can delete the snake_case client. It's better this way. |
Keep only the camelCase spawnThenToggle key, per review feedback.
76fc1f1 to
312d2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73
Windows spawned via IPC (e.g.
caelestia shell controlCenter open) ignore the[workspace special:X]exec rule, so the firstcaelestia toggle <ws>spawns the window on the current workspace and never opens the special workspace; only the second toggle moves it there.This adds a per-client
spawnThenToggleoption that dispatchestogglespecialworkspaceright after the client command is spawned, which is the approach Mestane tested and confirmed working in the issue thread.Default behaviour is unchanged: without the option set, toggling works exactly as before.