fix: support Claude Code hook format (matcher/hooks wrapper)#5
Merged
Conversation
upsert_hook now accepts hook_format="claude" to emit the
{"matcher":".*","hooks":[{"type":"command","command":"..."}]} structure
that Claude Code requires. install_claude_hooks() passes this format.
is_agent_learner_hook() detects both old and new formats for idempotent
upsert.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upsert_hook()now acceptshook_format="claude"to emit the{"matcher":".*","hooks":[{"type":"command","command":"..."}]}structure that Claude Code requiresinstall_claude_hooks()passeshook_format="claude"so Stop hooks are written correctlyis_agent_learner_hook()detects both simple{"command":"..."}and Claude Code{"matcher":...,"hooks":[...]}formats for idempotent upsertTest plan
install_claude_hooks()writes correct Claude Code format to settings.jsoninstall_claude_hooks()updates existing hook (idempotent)🤖 Generated with Claude Code