Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipx.mainmodule..venvand adds.venv/bintoGITHUB_PATH, so the real pipx console script runs with the Python environment where pipx is installed.pipx.main/pip install --user pipxsetup.Test Plan
uvx --from pyyaml python - <<'PY' ... yaml.safe_load(...) ... PYuv run pytest tests/test_published_install_smoke.py -q— 11 passeduv run pytest tests/ -q— 145 passedgit diff --checkPATH="$PWD/.venv/bin:$PATH" uv run python scripts/smoke_published_install.py --version 0.1.22 --attempts 1 --delay-seconds 0 --timeout 180— all npm/npx/npm-exec/uvx/pipx commands returned 0uv run python scripts/check_release_metadata.pyuv run python scripts/smoke_release_readiness.pyContext
The failed publish run
25145720909published npm/PyPI successfully, then failed before GitHub Release creation becausepublished-install-smokeretried the same pipx wrapper import error 36 times:ModuleNotFoundError: No module named 'pipx.main'