Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes hooks doctor/testpre-LLM payloads as dogfood observations while still exercising context injectionmemory_status_transitionson existing DB status update/history pathsVerification
memory_status_transitionsgapuv run pytest tests/test_cli.py::test_python_module_cli_approve_fact_migrates_existing_database_without_status_transition_table tests/test_cli.py::test_python_module_cli_retrieve_observe_records_secret_safe_local_observation tests/test_cli.py::test_python_module_cli_observations_audit_reports_frequent_and_stale_refs_without_raw_queries tests/test_cli.py::test_python_module_cli_observations_audit_reports_low_signal_empty_retrievals tests/test_cli.py::test_python_module_cli_observations_list_migrates_existing_database_without_observation_table tests/test_cli.py::test_python_module_cli_hermes_pre_llm_hook_outputs_context_for_hermes_shell_hook_payload tests/test_cli.py::test_python_module_cli_hermes_pre_llm_hook_skips_synthetic_doctor_observation tests/test_cli.py::test_python_module_cli_hermes_pre_llm_hook_injects_retrieved_memory_context -quv run pytest tests/ -q-> 173 passeduv run python scripts/check_release_metadata.pyuv run python scripts/smoke_release_readiness.pynpm pack --dry-rungit diff --checknode --check bin/agent-memory.jsquery_preview=None, no raw secret-like query text, audit warnings reportedfinding_count: 0Live Hermes QA
AM_LIVE_E2E_1777567838scoped to/Users/reddit/Project/agent-memory<agent_memory_context>,Retrieved fact, and the markerhermes --accept-hooks -z "What is the Hermes live E2E QA marker? Return only the marker and nothing else."answered with the markerreview explainshowed it is hidden from default retrievalmemory_status_transitionsmigration gap fixed in this PR