add net to status_right, solves #4#31
Open
HarHarLinks wants to merge 3 commits intocaiogondim:masterfrom
Open
Conversation
742e6de to
d9f0b4d
Compare
Owner
|
Would that run on macOS? |
Author
|
In short: I think it wouldn't break on macOS, but be a useless waste of space. (Just noting my thougths/to do:)
|
HarHarLinks
commented
Mar 24, 2018
| if [[ $PLUGINS == *"tmux-battery"* ]]; then | ||
| # if no battery can be found but the plugin is still enabled, this might result in some blank space in status-right | ||
| SHOW_BATTERY=true | ||
| if [ ! x"$(uname -s)" = x"Linux" ] || [[ "$(ls /sys/class/power_supply)" == *"BAT"* ]]; then |
Author
There was a problem hiding this comment.
Turns out, this is how it works later on in the battery function, so it is just as compatible.
While I believe this isn't perfect, it should work on linux as long as battery drivers work properly.
No Idea what happens on macOS without battery (iMac, Mac Pro) or how to handle it if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses unicode point f6ff (nf-mdi-ethernet) as defined by nerdfonts
todo(?): variate icon to indicate whether ethernet or wireless is connected