feat(cron): support configurable run timeouts - #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cron jobs need an explicit runtime budget because long data refreshes can legitimately exceed Moor’s existing ten-minute exec limit. This keeps the current default while allowing operators to raise it per cron.
Summary by cubic
Adds configurable per-cron run timeouts with a 10-minute default, so long-running jobs can exceed the previous limit. The timeout is validated, stored, and used during cron execution.
New Features
crons.timeout_ms(default 600,000 ms); migration v20.timeout_ms; strict validation (1 minute to 7 days); default applied if unset; scheduler passes timeout to container exec.@moor-sh/contract): types includetimeout_ms; exportedCRON_TIMEOUT_*constants andvalidateCronTimeoutMs.moor_cron_create/moor_cron_updateaccept and forwardtimeout_ms; tool descriptions and README document the default and 7-day max.Migration
Written for commit 7f61bfe. Summary will update on new commits.