Skip to content

PIVX integration - #3563

Open
Liquid369 wants to merge 11 commits into
cake-tech:devfrom
Liquid369:pivx-integration
Open

PIVX integration#3563
Liquid369 wants to merge 11 commits into
cake-tech:devfrom
Liquid369:pivx-integration

Conversation

@Liquid369

Copy link
Copy Markdown

Description

Adds PIVX, Transparent (P2PKH), and Sapling shielded.

Uses the bitcoin_base fork (Liquid369/bitcoin_base) for PIVX/Dogecoin confusion on base58 addresses.
PR: cake-tech/bitcoin_base#15.
I will fix the patch commit once it is cleared so everyone can test this pr if wanted/necessary.
Tested on Android and iOS sim: create/restore, all send routes (t->t, t->z,
z->t, z->z), transparent + shielded history, and memos.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@Liquid369 Liquid369 changed the title Pivx integration PIVX integration Aug 25, 2026
- add hive to deps (imported directly in pivx_wallet)
- rewindToHeight: free a reorged-out quarantined note (was stuck pending)
- receive label -> Shielded (Sapling)
- reword logs so the redaction scanner passes
- test harness: payment_uris import, nullable db close, path_provider stub
- balance-response tests: compare Money via amount, not raw int (Money migration)
- discovery tests: batch-boundary used indices for the current last-used gap scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant