Overwrite 'i18n extract' to make it able to parse twig templates too. - #121
Open
Antronin wants to merge 9 commits into
Open
Overwrite 'i18n extract' to make it able to parse twig templates too.#121Antronin wants to merge 9 commits into
Antronin wants to merge 9 commits into
Conversation
Antronin
marked this pull request as draft
August 18, 2026 13:17
Author
|
Can somebody help me with explaining:
|
Antronin
marked this pull request as ready for review
August 19, 2026 11:32
I think the 2 phpstan issues are connected to each other.
|
Author
|
Thanks, but that's not the error. In PHPUnit, I receive this error, but ONLY in CI: I'm not sure why the assert is a problem, even though the same PHP version (8.2.33) runs successfully in another CI task. And for the Coding Standard check, the error is this: That is not even my code, but Rector's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enchantment for Twig-View, for issue #91.
With these changes, users can still use
i18n extract, but it can now parse Twig files and collect all translations from them in the same way the original command does for PHP files.