Skip to content

test(mobile): cover event type update payload#127

Merged
dhairyashiil merged 6 commits into
mainfrom
codex/mobile-event-type-payload-tests
Jun 29, 2026
Merged

test(mobile): cover event type update payload#127
dhairyashiil merged 6 commits into
mainfrom
codex/mobile-event-type-payload-tests

Conversation

@dhairyashiil

Copy link
Copy Markdown
Member

Summary

  • Add focused Jest coverage for buildPartialUpdatePayload and hasChanges.
  • Cover no-op payloads, basic field diffs, multiple durations, location payloads, API v2 setting objects, and disabling advanced limits.
  • Keep this in Jest because the behavior is pure API payload construction; Maestro would duplicate a logic-level check.

Validation

  • bun run mobile:test
  • bunx biome ci apps/mobile/components/event-type-detail/utils/buildPartialUpdatePayload.test.js
  • git diff --check HEAD~1..HEAD

Refs ENG-1924.

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: cal-companion-mcp.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@dhairyashiil dhairyashiil force-pushed the codex/mobile-event-type-payload-tests branch from c1c3369 to 8b1d54d Compare June 27, 2026 19:09
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
cal-companion-chat Ignored Ignored Jun 28, 2026 9:24am

Request Review

@dhairyashiil dhairyashiil marked this pull request as ready for review June 28, 2026 05:49
@dhairyashiil dhairyashiil enabled auto-merge (squash) June 28, 2026 05:49

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread apps/mobile/app/(tabs)/(event-types)/event-type-detail.tsx
@dhairyashiil dhairyashiil merged commit d5ebfe2 into main Jun 29, 2026
14 of 16 checks passed
@dhairyashiil dhairyashiil deleted the codex/mobile-event-type-payload-tests branch June 29, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants