fix(mobile): use unconfirmed badge for pending requests#132
fix(mobile): use unconfirmed badge for pending requests#132dhairyashiil wants to merge 1 commit into
Conversation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
dhairyashiil
force-pushed
the
codex/mobile-use-unconfirmed-badge
branch
from
f246de6 to
519eba9
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mobile/components/screens/BookingDetailRequestActions.test.js">
<violation number="1" location="apps/mobile/components/screens/BookingDetailRequestActions.test.js:174">
P3: Test name describes behavior but body only asserts a constant's literal value.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }); | ||
| }); | ||
|
|
||
| test("uses the unconfirmed badge label when the current user cannot respond", () => { |
There was a problem hiding this comment.
P3: Test name describes behavior but body only asserts a constant's literal value.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mobile/components/screens/BookingDetailRequestActions.test.js, line 174:
<comment>Test name describes behavior but body only asserts a constant's literal value.</comment>
<file context>
@@ -169,4 +170,8 @@ describe("getBookingRequestActionState", () => {
});
});
+
+ test("uses the unconfirmed badge label when the current user cannot respond", () => {
+ expect(BOOKING_REQUEST_BADGE_LABEL).toBe("Unconfirmed");
+ });
</file context>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| now?: Date; | ||
| }; | ||
|
|
||
| export const BOOKING_REQUEST_BADGE_LABEL = "Unconfirmed"; |
There was a problem hiding this comment.
🚩 Attendees now see a generic label instead of an informative one
Previously, attendees (non-host users) viewing a pending booking saw "Pending host confirmation", which told them the booking was waiting on the host. Now all users see the generic "Unconfirmed" label. This is a user-facing behavior change that affects how attendees understand the status of their booking requests. The PR doesn't state intent for this change, so it's worth confirming this is the desired product behavior — attendees lose the signal that the ball is in the host's court.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
What changed
Unconfirmedinstead ofPending host confirmation.Verification
bun test apps/mobile/components/screens/BookingDetailRequestActions.test.jsbun --filter mobile test --runInBandbun --filter mobile typecheckbunx biome check apps/mobile/utils/booking-request-actions.ts apps/mobile/components/booking-list-item/BookingListItemParts.tsx apps/mobile/components/booking-list-item/BookingListItem.tsx apps/mobile/components/booking-list-item/BookingListItem.ios.tsx apps/mobile/components/booking-list-item/RecurringBookingListItem.tsx apps/mobile/components/booking-list-item/RecurringBookingListItem.ios.tsx apps/mobile/components/screens/BookingDetailScreen.tsx apps/mobile/components/screens/BookingDetailScreen.ios.tsx apps/mobile/components/screens/BookingDetailRequestActions.test.jsgit diff --checkrg -n "Pending host confirmation" apps/mobile(no matches)