Conversation
🦋 Changeset detectedLatest commit: efab2cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shirakaba
left a comment
There was a problem hiding this comment.
Some initial thoughts. I'm not too familiar with the Ferric stuff, so I defer to others.
|
I fixed conflicts multiple times in these PRs, will there be a merge? If not, better to close them. As for bad commit messages, you can squash merge, always cleaner to have one based on PR title. I doubt rollbacks ever happens, most likely fixes are done on top of what is done. |
|
I hope to be looking into adding an init command to ferric in the coming weeks (I could use it myself to bisect a regression across React Native versions). I don't know yet if that will be based off this PR or something written from scratch, but I'll make sure to take a thorough look here before I get started 👍 Generally speaking, briefly looking over this PR it has too many unrelated changes IMO and is very unlikely to merge as is. We want smaller, increments based off issues with s clear scope and at least some upfront design discussion (which I expect the contributor to drive) 💙 |
|
Well, the changes are still in the context of it. Unless you mean something more than ferric-example, not sure what that would be. The replacing were due to leaving it accordingly to the init. Hence still in the context. |
initcommand to generate / scaffold the project.ferric-examplewithapp-test, scaffolding the project there.Cargo.tomloptimizations for size. Reduce native files size #196Ideally merge #205 first.