chore: extract "bundle react native code and images" to a standalone script#283
Open
adhorodyski wants to merge 7 commits intomainfrom
Open
chore: extract "bundle react native code and images" to a standalone script#283adhorodyski wants to merge 7 commits intomainfrom
adhorodyski wants to merge 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adhorodyski
commented
Apr 25, 2025
packages/platform-ios/template/ios/bundle-react-native-code-and-images.sh
Outdated
Show resolved
Hide resolved
satya164
reviewed
Apr 25, 2025
packages/platform-ios/template/ios/bundle-react-native-code-and-images.sh
Outdated
Show resolved
Hide resolved
adhorodyski
force-pushed
the
feat/ios-extract-bundle-script
branch
from
50427cd to
8b05212
Compare
thymikee
reviewed
May 6, 2025
thymikee
requested changes
May 6, 2025
Contributor
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
This needs documentation update, some testing and we're good to go 👍🏼
adhorodyski
force-pushed
the
feat/ios-extract-bundle-script
branch
from
dc704aa to
3bc8a46
Compare
satya164
reviewed
May 26, 2025
satya164
reviewed
May 26, 2025
website/docs/docs/getting-started/migrating-from-community-cli.mdx
Outdated
Show resolved
Hide resolved
adhorodyski
commented
May 26, 2025
Collaborator
Author
|
@thymikee what is the testing flow for a new template (locally)? |
Contributor
thymikee
force-pushed
the
main
branch
4 times, most recently
from
3d96b7a to
22c004e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing template relies on an inlined shellScript inside of the iOS project definition for RN scripts. This is hard to maintain and provides very bad git diff experience.
This PR addressed that by extracting the shell script into a separate file that diffs well allowing teams to review changes more easily.
Test plan
Apps created with the new template should include a new
ios/react-native-xcode.shfile.