Open
Conversation
szymonrybczak
approved these changes
Dec 4, 2024
Contributor
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
small nits! amazing how composable plugins are 💯
| if (config) { | ||
| await createBuild('visionos', config, args as BuildFlags); | ||
| } else { | ||
| throw new Error('visionOS project not found.'); |
Contributor
There was a problem hiding this comment.
i see that we have v similar errors across codebase when we can't find config. we should find a nice way or do a writeup in docs how to proceed with such case
Comment on lines
63
to
77
| xcworkspace=$(find . -maxdepth 1 -name '*.xcworkspace' -type d | head -1) | ||
| xcodebuild \ | ||
| -workspace "${xcworkspace}" \ | ||
| -scheme "${{inputs.scheme}}" \ | ||
| -destination "generic/platform=visionOS Simulator" \ | ||
| -configuration Debug \ | ||
| -derivedDataPath DerivedData \ | ||
| ARCHS="${{inputs.architectures}}" \ | ||
| CODE_SIGNING_ALLOWED=NO \ | ||
| CLANG_ADDRESS_SANITIZER=NO \ | ||
| CLANG_UNDEFINED_BEHAVIOR_SANITIZER=NO \ | ||
| OTHER_CFLAGS='$(inherited) -fno-sanitize=undefined -fno-sanitize=bounds -fstack-protector-strong' \ | ||
| OTHER_LDFLAGS='$(inherited) -fno-sanitize=undefined -fno-sanitize=bounds -fstack-protector-strong' \ | ||
| COMPILER_INDEX_STORE_ENABLE=NO \ | ||
| build |
Contributor
There was a problem hiding this comment.
can't we use build:vision? with --extra-params ofc
Contributor
Author
There was a problem hiding this comment.
I guess we can, but I need @mdjastrzebski to test this. for now I'd keep it this way
okwasniewski
reviewed
Dec 5, 2024
okwasniewski
reviewed
Dec 5, 2024
|
|
||
| @implementation HelloWorldTests | ||
|
|
||
| - (BOOL)findSubviewInView:(UIView *)view matching:(BOOL (^)(UIView *view))test |
Collaborator
There was a problem hiding this comment.
These tests don't need to be in the template, I've removed them in 0.77
Contributor
Author
There was a problem hiding this comment.
yup, will update that once we migrate the templates to 0.77 :)
thymikee
force-pushed
the
feat/run-ios
branch
2 times, most recently
from
4b93420 to
5bbd4a7
Compare
thymikee
force-pushed
the
feat/visionos
branch
from
f23a5f9 to
4359a98
Compare
thymikee
force-pushed
the
feat/visionos
branch
from
fadb21b to
2c35ca8
Compare
thymikee
force-pushed
the
main
branch
2 times, most recently
from
f25b722 to
c5e0a0c
Compare
thymikee
force-pushed
the
main
branch
4 times, most recently
from
3d96b7a to
22c004e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add visionOS platform. cc @okwasniewski
Builds on #41
Test plan