Skip to content

WIP fix: fallback to checking for buildType if the flavor-less apk is not found#608

Open
thymikee wants to merge 1 commit intomainfrom
fix/android-build-output
Open

WIP fix: fallback to checking for buildType if the flavor-less apk is not found#608
thymikee wants to merge 1 commit intomainfrom
fix/android-build-output

Conversation

@thymikee
Copy link
Contributor

@thymikee thymikee commented Oct 16, 2025

This is still not bulletproof, but will handle one more case:

  • buildType that are camelCase instead of just "debug" or "release"

Cases that the findBuildOutput still doesn't support:

  • flavor + buildType (e.g. stagingDebug for staging flavor)
  • just buildType when there are flavors (e.g. debug for staging flavor, will produce 2 APKs)

Todo: unit tests

What I tried and failed:

  • getting the latest build file based on mtime but:
    • Gradle may produce 2 APKs from the same build and this is causing issues
    • Gradle may not overwrite the existing APK so we'd pick a stale one

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rock Ignored Ignored Oct 16, 2025 0:31am

@thymikee thymikee linked an issue Oct 16, 2025 that may be closed by this pull request
@thymikee thymikee force-pushed the main branch 4 times, most recently from 3d96b7a to 22c004e Compare January 20, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rock build:android doesn't create cache

1 participant