Skip to content

fix: filename can be nil#35

Open
phanen wants to merge 1 commit intocalops:mainfrom
phanen:fix
Open

fix: filename can be nil#35
phanen wants to merge 1 commit intocalops:mainfrom
phanen:fix

Conversation

@phanen
Copy link

@phanen phanen commented Jan 29, 2026

vim.schedule callback: vim/treesitter/languagetree.lua:215:
vim/filetype.lua:3160: At least one of "buf", "filename", or "contents"
must be given

vim.schedule callback: vim/treesitter/languagetree.lua:215:
vim/filetype.lua:3160: At least one of "buf", "filename", or "contents"
must be given
@gemini-code-assist
Copy link

Summary of Changes

Hello @phanen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical runtime error that occurred when the filename variable, derived from find_filename_in_parent_node, was nil before being passed to vim.filetype.match. The change introduces a defensive nil check, ensuring the application handles cases where a filename cannot be determined, thereby preventing crashes and improving the overall stability of the hmts_inject_handler logic.

Highlights

  • Error Prevention: Implemented a nil check for the filename variable within the hmts_inject_handler function to prevent a runtime error.
  • Robustness Improvement: Ensures that the vim.filetype.match function is not called with a nil filename, resolving an issue where find_filename_in_parent_node might return nil.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a potential crash that occurs when find_filename_in_parent_node returns nil. The added check prevents vim.filetype.match from being called with a nil filename, which resolves the error mentioned in the description. I've added a minor suggestion to make the guard clause more concise and idiomatic.

Comment on lines +157 to +159
if filename == nil then
return
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better conciseness and to follow Lua idioms, you can use a one-line guard clause. In Lua, nil is falsy, so you can check for it with if not filename then ... end.

	if not filename then return end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant