fix(gitea-mq): match the required-check fallback to the authoritative ruleset - #3015
Merged
Conversation
… ruleset Ruleset 16212553 requires nixbot/nix-eval, nixbot/nix-build and nixbot/effects; the module's fallback listed only the first two. The fallback does not fire today, because ResolveRequiredChecks prefers a non-empty forge-derived list, but a fallback weaker than the forge is worse than none: it would silently reduce the gate exactly when the forge reports nothing. The downgrade path is narrower than a missing ruleset. GetRequiredChecks errors propagate rather than falling back, so an unreadable ruleset or lost read access stalls the queue instead of weakening it. The fallback fires only on a successful empty list — a ruleset deleted, emptied, retargeted off the default branch, or reduced to gitea-mq-owned contexts, which GetRequiredChecks subtracts. Second coupling, recorded because it is the one that bites: nixbot/effects is posted only when at least one effect runs. effects_run.py returns early on an empty effect set, so effects_started is never called and the context is never posted. A required check that is never posted blocks a PR rather than failing it, so requiring it is safe only while the default branch keeps effects_on_pull_requests true with a non-empty effect set. nixbot.toml and this list must move together. Change-Id: I06bf0508cf3cd63abb483139e7fe36786a6a6964
Owner
Author
|
This pull request is part of a Mergify stack:
|
cameronraysmith
added this pull request to stack #3016
September 10, 2026 04:15
Base automatically changed from
stack/cameronraysmith/stack/queue-cutover/raise-batch-cap-twenty-flake-update-waves--fc76b011
to
main
September 10, 2026 04:27
sciexp-gitea-mq
Bot
deleted the
stack/cameronraysmith/stack/queue-cutover/match-required-check-fallback-authoritative--06bf0508
branch
September 10, 2026 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruleset 16212553 requires nixbot/nix-eval, nixbot/nix-build and
nixbot/effects; the module's fallback listed only the first two. The fallback
does not fire today, because ResolveRequiredChecks prefers a non-empty
forge-derived list, but a fallback weaker than the forge is worse than none:
it would silently reduce the gate exactly when the forge reports nothing.
The downgrade path is narrower than a missing ruleset. GetRequiredChecks
errors propagate rather than falling back, so an unreadable ruleset or lost
read access stalls the queue instead of weakening it. The fallback fires only
on a successful empty list — a ruleset deleted, emptied, retargeted off the
default branch, or reduced to gitea-mq-owned contexts, which GetRequiredChecks
subtracts.
Second coupling, recorded because it is the one that bites: nixbot/effects is
posted only when at least one effect runs. effects_run.py returns early on an
empty effect set, so effects_started is never called and the context is never
posted. A required check that is never posted blocks a PR rather than failing
it, so requiring it is safe only while the default branch keeps
effects_on_pull_requests true with a non-empty effect set. nixbot.toml and
this list must move together.