[WIP] [Proposal] Rename stream submodules to improve readability#1795
Open
peaBerberian wants to merge 1 commit intodevfrom
Open
[WIP] [Proposal] Rename stream submodules to improve readability#1795peaBerberian wants to merge 1 commit intodevfrom
peaBerberian wants to merge 1 commit intodevfrom
Conversation
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
5bc70cb to
415eb5c
Compare
61f982a to
9ee585d
Compare
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the
Stream(the module and submodules determining which segments need to be loaded), I thought that the current architecture was relatively difficult to follow. For example, the submodules inside it are hierarchical and follow aStreamOrchestrator>PeriodStream>AdaptationStream>RepresentationStreampath.It makes relative sense when you know DASH and think a little about it, but I feel that it could be improved on.
For now, I'm not set on what we could name it, I just searched-and-replaced and tried different things.
Notably, directories inside
src/core/streamare now numbered and indicates what job they have:(instead of
orchestrator/,period/,adaptation/andrepresentation/respectively)And the modules themselves have also been renamed for what they do (e.g.
TrackSelector) instead of the DASH abstraction level they're at like before (likePeriodStream). But I'm still not 100% happy with that.This is background work not important for the other work I was doing (which is implementing more resilience on decoding errors) but it is something I saw so I thought I would open a PR so we can think about how we could improve on this.