fix: reject 'cwd' key in integration-suites with a clear error#53
Closed
javierdelapuente wants to merge 1 commit into
Closed
fix: reject 'cwd' key in integration-suites with a clear error#53javierdelapuente wants to merge 1 commit into
javierdelapuente wants to merge 1 commit into
Conversation
The 'cwd' key was renamed to 'working-dir' in #50. Previously a stale 'cwd:' entry in spread.yaml would silently pass through to spread as an unknown key. Now _build_suite_entry raises ConfigurationError with a migration message directing users to 'working-dir'. The opcli-key extraction is refactored into _pop_opcli_keys to keep _build_suite_entry under the C901 complexity limit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Closing — the code already has no cwd support after #50. No changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cwdkey inintegration-suiteswas renamed toworking-dirin #50. Previously, a stalecwd:entry inspread.yamlwould silently pass through to spread as an unknown key.Changes
_build_suite_entrynow raisesConfigurationErrorimmediately ifcwdis found, with a message directing users toworking-dir_pop_opcli_keyshelper to keep_build_suite_entryunder the C901 complexity limittest_cwd_key_raises_configuration_errorinTestExplicitSuiteValidation