[DPE-9962] Rename default Patroni config to avoid missconfigurations#271
Open
taurus-forever wants to merge 1 commit into
Open
[DPE-9962] Rename default Patroni config to avoid missconfigurations#271taurus-forever wants to merge 1 commit into
taurus-forever wants to merge 1 commit into
Conversation
taurus-forever
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot and
marceloneppel
and removed request for
a team
Member
marceloneppel
left a comment
marceloneppel
left a comment
There was a problem hiding this comment.
Should
be removed as well?
Contributor
Author
This is an excellent catch! Thank you! |
Member
I think it's worth adding. |
…urations Sometimes, due to complex deployment instabilities, Charmed PostgreSQL snap can be installed already on machine by charm.py operator and launched by systemd/snapd on reboot, etc... effectively staring with wrong configs. The file could be removed completely, but one day we hope to ship rock usable without the charm. If config file is missing, Patroni failfast causing no damage/garbage in pgdata.
taurus-forever
force-pushed
the
alutay/snap_rm_conf
branch
from
df1643c to
76d3450
Compare
Contributor
Author
It will be the followup work, as we see a bunch of necessary changes (e.g. chown will fain on new installation, etc), let's keep commits atomic. |
taurus-forever
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes, due to complex deployment instabilities, Charmed PostgreSQL snap can be installed already on machine by charm.py operator and launched by systemd/snapd on reboot, etc... effectively staring with wrong configs.
Solution
Rename default config to avoid Patroni staring with wrong config paramts.
If config file is missing, Patroni failfast causing no damage/garbage in pgdata.
Could removed completely, but one day we hope to ship it usable without the charm.