feat: add maintenance to the reference#22
Conversation
b316376 to
4776eed
Compare
cjdcordeiro
left a comment
There was a problem hiding this comment.
this is v2 specific right? So I think we need to also update the top of chisel.yaml.md, to add and the format version, and maybe add a column to these new attributes, to state that they are only available in v2
cjdcordeiro
left a comment
There was a problem hiding this comment.
Thanks for the changes @letFunny . I think we still need the change related to the introduction of v2
I misunderstood your other comment then in MM. I thought we were going to add versioning to the docs in the sense of browsing docs per chisel version. I will add a column here for compatibility, maybe saying |
|
@cjdcordeiro I have added the attribute "compatibility" for all values with either:
Please tell me what you think. An alternative would be to only include for fields where it is not the default but I think it is better to be consistent and put it everywhere. |
cjdcordeiro
left a comment
There was a problem hiding this comment.
It looks nice, thanks!
Y the docs versioning is a separate complement, since it covers anything within Chisel (e.g. CLI changes, UX changes, etc.) while this part here is just about the chisel.yaml.
I'm a bit concerned about the maintainability of these tables, cause as we add/remove stuff, it will be really easy to mess up the compatibilities. I wish this could be generated from code, but it's good enough for now.
Thanks again
|
Feel free to merge once the Chisel counterpart is merged too |
4e10951 to
f44243a
Compare
|
Sorry for force-pushing, it was complaining about signatures. |
f44243a to
a63a00f
Compare
|
@cjdcordeiro, Paul reminded me today about this PR. Can we merge? Why is it saying |
Signed-off-by: Alberto Carretero <angelalbertoc.r@gmail.com>
a63a00f to
eb7a203
Compare
|
My bad, it was |
|
@letFunny there's a "typo" it seems -> https://github.com/canonical/chisel-docs/actions/runs/21945091839/job/63380519254?pr=22 not really a typo, but either change the wording or add the term to wordlist |
|
@cjdcordeiro Done |
The idea is that the reference for maintenance will be shown when using unmaintainted or unstable releases, see canonical/chisel#238 (comment) for context.
The goal of this PR is to write down all ideas and to see if the reference is a good page to show in Chisel's output (again, see github comment above for context).