feat: [WD-33240] Full Site View#315
Merged
Merged
Conversation
- Rename selectedProject to activeProject in IViewsStore to avoid naming collision with IStore.selectedProject (different type) - Fix regex bug in selectTableView test helper - Move headers to module-level constant - Remove unnecessary gap: 0 in SCSS
URL cells wrap at any character so long URLs remain fully readable. Title cells truncate to a single line with ellipsis; a native hover tooltip exposes the full text. Also tightens the sidebar: zero horizontal padding on the drawer, alt background, and a highlighted background for the active project.
- Add FullSiteView.test.tsx with smoke test and mocks for panels/modals - Include pre-staged table header, status dot, and pagination tweaks
Connects row-level contextual menu to Copy update, Page refresh, and Remove page actions; renders singleton panels/modal outside the row loop.
MainTable.Header accepts className; classNames was being forwarded to the <th> DOM element, leaving the Actions column header un-centered and logging a React prop warning on every render.
| {!isLoading && ( | ||
| <div className="full-site-view__content-table-footer"> | ||
| <hr className="p-rule" /> | ||
| <TablePagination |
Contributor
There was a problem hiding this comment.
The current pagination shows "10 out of Total pages", no matter the current page.
Can we do something like we did on assets pagination, so the count updates to reflect current page?
Contributor
Author
There was a problem hiding this comment.
You mean on page 2, showing something like
Showing 20 out of Total pages?
Contributor
There was a problem hiding this comment.
Yes, we've done something similar for assets pagination.
Centralises the admin-or-owner-or-reviewer rule into a single tested helper, replacing the ad-hoc checks scattered across multiple components.
muhammad-ali-pk
approved these changes
May 8, 2026
Contributor
muhammad-ali-pk
left a comment
muhammad-ali-pk
left a comment
There was a problem hiding this comment.
LGTM! Approving with couple minor comments.
muhammad-ali-pk
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA Needed
Review: Code Needed
labels
…ssage - Extract Next button onClick into handleNext useCallback in RequestCopydocPanel and RequestRemovalPanel. - Use the same denial wording across tooltips and toast bodies: "Only the page owner, contributors, or an admin can perform actions".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Refactored the Full Site View
QA steps
Checkout this pull request
Run the project using task
Access the application on localhost:8104/app
Go to Full Site View
Verify pages are displayed and looks as per figma
Verify clicking on a project shows it's pages
Verify the Side panel appears when you try to click an action
Verify that the search works
Verify that the filter works
Second part of the PR is here
#321
Fixes
Screenshots
It could be helpful to provide some screenshots to aid in QAing the change.