cli: add platform string override and de-deuplicate use of HANDLE #174
Draft
artiepoole wants to merge 12 commits intoartie/dfx-mgr-testsfrom
Draft
cli: add platform string override and de-deuplicate use of HANDLE #174artiepoole wants to merge 12 commits intoartie/dfx-mgr-testsfrom
artiepoole wants to merge 12 commits intoartie/dfx-mgr-testsfrom
Conversation
artiepoole
force-pushed
the
artie/cli-rework
branch
from
99dfa1f to
0a4c15b
Compare
artiepoole
force-pushed
the
artie/dfx-mgr-tests
branch
from
545474a to
381642c
Compare
HANDLE is now either --device or --name (for overlays) Signed-off-by: Artie Poole <stuart.poole@canonical.com>
test use of --device, --name, --platform Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
…tring Signed-off-by: Artie Poole <stuart.poole@canonical.com>
this allows the same fpgad app to provide permissions to access fpga and other interfaces without duplication an alternative approach would be to use a wrapper script to run fpgad itself, but this seems messier Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
…'s been done Signed-off-by: Artie Poole <stuart.poole@canonical.com>
artiepoole
force-pushed
the
artie/dfx-mgr-tests
branch
from
381642c to
64bf17f
Compare
artiepoole
force-pushed
the
artie/cli-rework
branch
from
7c6fc51 to
2964294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HANDLE is now either --device or --name (for overlays)
added --platform as a top level argument
added rudimentary tests to the snap test suite