Skip to content

feat(github): add GitHub App authentication to github-runner-manager#775

Merged
cbartz merged 1 commit into
mainfrom
feat/github-app-auth
Apr 1, 2026
Merged

feat(github): add GitHub App authentication to github-runner-manager#775
cbartz merged 1 commit into
mainfrom
feat/github-app-auth

Conversation

@cbartz
Copy link
Copy Markdown
Collaborator

@cbartz cbartz commented Mar 31, 2026

Overview

Add GitHub App authentication as an alternative to PAT tokens. Includes configuration models, client changes, and tests.

Does not include charm wiring and docs update to keep PR size small. There will be a follow-up PR containing the charm adaptions.

Original draft PR that contained all changes and copilot review iterations: #774

Rationale

GitHub App authentication provides 3x rate limits for enterprises and does also decouple authentication from specific persons. E.g., with PAT's, it is always required that the person owning the PAT is really an admin on a repository in order to register self-hosted runners.

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

change log and docs will be updated in a follow-up PR.

Comment thread github-runner-manager/tests/integration/test_github_app_auth.py
Comment thread github-runner-manager/tests/integration/test_github_app_auth.py
@cbartz cbartz marked this pull request as ready for review March 31, 2026 13:44
Add GitHub App authentication as an alternative to PAT tokens.
Includes configuration models, client changes, and tests.
@cbartz cbartz force-pushed the feat/github-app-auth branch from cfb5667 to 5d97db1 Compare March 31, 2026 14:27
Copy link
Copy Markdown
Contributor

@florentianayuwono florentianayuwono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks chris lgtm 👍

@cbartz cbartz enabled auto-merge (squash) April 1, 2026 05:35
@cbartz cbartz merged commit 1c08b2d into main Apr 1, 2026
149 of 184 checks passed
@cbartz cbartz deleted the feat/github-app-auth branch April 1, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants