fix(charm): check image readiness before starting runner manager service#777
Merged
Conversation
Several event handlers (_on_upgrade_charm, _on_planner_relation_changed, _on_planner_relation_broken) called _reconcile() without first checking image readiness. This caused the runner manager service to start with empty runner combinations, erroring with "No runner combinations configured" instead of setting the charm to blocked/waiting status. Move _check_image_ready() into _reconcile() so all code paths that start the service are covered, and remove the now-redundant calls from individual handlers.
yhaliaw
approved these changes
Apr 6, 2026
florentianayuwono
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Moved _check_image_ready() into _reconcile() so every code path that starts the runner manager service first verifies the image integration has an available image.
Rationale
Several event handlers (_on_upgrade_charm, _on_planner_relation_changed, _on_planner_relation_broken) called _reconcile() without checking image readiness. This caused the service to start with combinations: [] and error with "No runner
combinations configured" instead of setting the charm to blocked/waiting status.
Juju Events Changes
No new events. Existing handlers _on_upgrade_charm, _on_planner_relation_changed, _on_planner_relation_broken, _on_config_changed, _on_image_relation_changed, and _on_debug_ssh_relation_changed now all go through _reconcile() for image readiness
checks. Redundant _check_image_ready() calls removed from the latter three.
Module Changes
Library Changes
None.
Checklist