Skip to content

Update action dashboard variable settings#223

Merged
weiiwang01 merged 3 commits into
mainfrom
action-dashboard
Jun 3, 2026
Merged

Update action dashboard variable settings#223
weiiwang01 merged 3 commits into
mainfrom
action-dashboard

Conversation

@weiiwang01
Copy link
Copy Markdown
Collaborator

What this PR does

Update the includeAll setting of the github_runner, github_run_id, and github_run_attempt variables for a better dashboard default experience.

Screenshot from 2026-06-03 14-45-59

Why we need it

Checklist

  • Changes comply with the project's coding standards and guidelines (see CONTRIBUTING.md and STYLE.md)
  • CONTRIBUTING.md has been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)
  • Technical author has been assigned to review the PR in case of documentation changes (usually *.md files)
  • I updated docs/changelog.md with user-relevant changes
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors
  • If this PR involves Rockcraft: I updated the version

Copy link
Copy Markdown
Collaborator

@florentianayuwono florentianayuwono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did some of these set to true and some set to false?

@weiiwang01
Copy link
Copy Markdown
Collaborator Author

why did some of these set to true and some set to false?

When the includeAll was set to false for the github_runner variable, when the user first enters the dashboard, it will pre-select a github_runner in the variable. This may not be a very good UX experience, as the GitHub runner name is hidden from the general user.

In this pull request, I change the includeAll of github_runner to true and github_run_id and github_run_attempt to false, so that when the user first enters the dashboard, it will pre-select a github_run_id, which is more intuitive to users.

@weiiwang01 weiiwang01 merged commit c5d4af5 into main Jun 3, 2026
46 of 48 checks passed
@weiiwang01 weiiwang01 deleted the action-dashboard branch June 3, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants