Add icons to collapsed buttons inside dropdowns#545
Add icons to collapsed buttons inside dropdowns#545gesquivelgaghi wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds icon support for actions that are collapsed into the ResponsiveButtons dropdown so dropdown items can render the same icon+label content as the original buttons.
Changes:
- Introduce
hasIcon?: booleanplumbing throughResponsiveButtonsso collapsed menu items can be styled correctly when they include icons. - Preserve original button
childrenwhen collapsing actions, enabling icon+label nodes to render inside dropdown items. - Update several action button groups (snaps, packages, instances) to set
hasIconso their collapsed dropdown items render with icons.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/features/snaps/components/SnapsActions/SnapsActions.tsx |
Marks snap action buttons with hasIcon so collapsed dropdown entries render with icon styling. |
src/features/packages/components/PackageActions/PackageActions.tsx |
Marks package action buttons with hasIcon for icon-aware collapsed rendering. |
src/features/instances/components/InstancesPageActions/InstancesPageActions.tsx |
Adds icons/hasIcon to instance action buttons and updates Pro token action labeling logic. |
src/components/ui/ResponsiveButtons/types.ts |
Extends button-like props to optionally carry hasIcon. |
src/components/ui/ResponsiveButtons/ResponsiveButtons.tsx |
Propagates hasIcon and preserves original children for collapsed items so icons can render in the dropdown. |
.changeset/fluffy-hotels-divide.md |
Adds a patch changeset describing the UI fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rubinaga
left a comment
There was a problem hiding this comment.
@gesquivelgaghi I think it would be nice if the chevron was "chevron left" here and in line with the other icons (on the left). What do you think?
|
@rubinaga the reason I left it as is, is because it the dropdown options are about to change to these: |
|
@gesquivelgaghi won't that somehow be a bit worse in that case when all are combined under "Actions"? because the chevron will be pointing to the right, but there will never be space to be opened to the right so they always will end up left. I think this pattern is only in this "Instances page" in the "actions", and in the "filters" so I don't think we have a set pattern in the project yet. I don't think its a big deal if one points left and the other right but could be worth bringing up with Dani I guess |


Summary
Added icons to the buttons inside the dropdown of
ResponsiveButtonsRelease Impact
According to the Landscape Server Release Cycle, this change will target the following release cycle:
main(Beta)Checklist
pnpm changesetand committed the resulting.mdfile.scripts/).Versioning Reminder
Important
This repository now uses CalVer ($YY.0M.Point.Patch$ ).
Please ensure your changeset description is clear, as it will be automatically added to the
CHANGELOG.mdupon merging tomain.UI Changes
Before:



After:

