Merged
Conversation
marqode
reviewed
Apr 22, 2026
Contributor
marqode
left a comment
There was a problem hiding this comment.
Consider using the array destructure pattern const [, hwRoot] = hwDotMatch; for the lint warnings in SavedSearchForm/helpers. Otherwise we could suppress that warning globally if it's not helpful.
When I ran tests with coverage on searchQueryHelpers.test.ts it showed only 6% for searchQueryLanguage.ts. Could be worth generating tests to cover more of the query cases.
Otherwise lgtm!
marqode
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR deals with this Jira ticket
Missing search terms were added to both the "?" search term helper in the instances page, as well as in the saved searches form.
The saved search form no longer blocks the user from submitting a search when the wrong search parameters have been used. It only warns them with a warning shown below the input.
Release Impact
According to the Landscape Server Release Cycle, this change will target the following release cycle:
dev/main(Beta)Checklist
pnpm changesetand committed the resulting.mdfile.scripts/).Versioning Reminder
Important
This repository now uses CalVer ($YY.0M.Point.Patch$ ).
Please ensure your changeset description is clear, as it will be automatically added to the
CHANGELOG.mdupon merging tomain.