Skip to content

fix: add missing search terms#559

Merged
rubinaga merged 3 commits intomainfrom
fix/add-missing-parameters-to-saved-searches
Apr 28, 2026
Merged

fix: add missing search terms#559
rubinaga merged 3 commits intomainfrom
fix/add-missing-parameters-to-saved-searches

Conversation

@rubinaga
Copy link
Copy Markdown
Contributor

Summary

This PR deals with this Jira ticket

Missing search terms were added to both the "?" search term helper in the instances page, as well as in the saved searches form.
The saved search form no longer blocks the user from submitting a search when the wrong search parameters have been used. It only warns them with a warning shown below the input.

Release Impact

According to the Landscape Server Release Cycle, this change will target the following release cycle:

  • Target Branch: dev / main (Beta)
  • Version Impact:
    • Patch (Fix)
    • Minor (Feature)
    • Major (Breaking)

Checklist

  • Changeset Added: I have run pnpm changeset and committed the resulting .md file.
  • UI Verified: I have verified the changes locally.
  • Linting: No linting errors are present (especially in scripts/).

Versioning Reminder

Important

This repository now uses CalVer ($YY.0M.Point.Patch$).
Please ensure your changeset description is clear, as it will be automatically added to the CHANGELOG.md upon merging to main.

Copy link
Copy Markdown
Contributor

@marqode marqode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the array destructure pattern const [, hwRoot] = hwDotMatch; for the lint warnings in SavedSearchForm/helpers. Otherwise we could suppress that warning globally if it's not helpful.

When I ran tests with coverage on searchQueryHelpers.test.ts it showed only 6% for searchQueryLanguage.ts. Could be worth generating tests to cover more of the query cases.

Otherwise lgtm!

@rubinaga rubinaga merged commit aeead5e into main Apr 28, 2026
6 of 7 checks passed
@rubinaga rubinaga deleted the fix/add-missing-parameters-to-saved-searches branch April 28, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants